Skip to content

fix(express): Fix test for root route handling #16375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented May 23, 2025

I'm waiting for a review of this PR in OTel: open-telemetry/opentelemetry-js-contrib#2843

After this is reviewed/merged, we can vendor it in again and make sure the E2E test works.

@andreiborza
Copy link
Member

@s1gr1d I added these to our express integration tests on the OTel v2 branch (and they pass 🎉 ). See 4f9eeed. I think we can close this PR, wdyt?

@s1gr1d
Copy link
Member Author

s1gr1d commented Jul 16, 2025

Nice, thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants